Opened on 01/26/2018 at 05:16:30 PM
Closed on 03/22/2018 at 03:58:52 PM
#6329 closed change (fixed)
Add support for $csp filter option to core
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sergz, sebastian, mjethani, hfiguiere, mapx, fanboy, arthur | Blocked By: | |
| Blocking: | #5241 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29680684/ |
||
Description
Background
For #5241 we're adding support for the $csp filter option to adblockpluschrome, but before we can do that we need to add the filter option to the core code.
What to change
- Modify the filter code so that filters can contain whitespaces where necessary, since whitespace is significant in Content Security Policies.
- Add the $csp filter option itself, make sure it's not enabled by default. If the value includes "report-to" throw an "filter_invalid_csp" InvalidFilter.
Attachments (0)
Change History (4)
comment:1 Changed on 01/26/2018 at 06:13:57 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/29/2018 at 09:23:29 AM by arthur
- Cc arthur added
comment:3 Changed on 03/22/2018 at 03:57:52 PM by abpbot
comment:4 Changed on 03/22/2018 at 03:58:52 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6329 - Add the CSP filter option