Opened on 02/05/2018 at 05:54:03 PM
Closed on 09/05/2019 at 05:05:41 PM
#6358 closed defect (duplicate)
Correct resource URL colours for dark theme version of our developer tools panel
| Reported by: | kzar | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | goodfirstbug |
| Cc: | greiner, mapx, jeen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Environment
Unknown version of Chrome, with developer tools set to dark theme.
Uknown version of Adblock Plus.
How to reproduce
- Open the developer tools for a tab, switch to the Adblock Plus pane.
- Browse to https://adblockplus.org in the tab.
Observed behaviour
The resource URLs listed in the Adblock Plus developer tools pane are extremely hard to read - dark grey on grey.
Expected behaviour
The URLs are easier to read.
What to change
Improve dark theme support in our DevTools panel by using colors with better contrast for texts, links, backgrounds and other UI elements.
See ui#194.
Notes
- Perhaps we should reevaluate all the colours used for the dark theme version, since I just picked those (#4136) and I'm no designer.
- This was probably made worse by my changes for #6035 (turning the URLs into links).
- This issue is based on a report in the forum which mapx highlighted.
Attachments (0)
Change History (7)
comment:3 Changed on 02/07/2018 at 09:50:24 AM by greiner
- Cc jeen added
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 02/07/2018 at 10:01:36 AM by greiner
- Keywords goodfirstbug added
comment:5 Changed on 09/07/2018 at 03:25:57 PM by greiner
- Ready unset
We now have a spec for the DevTools panel but don't mention the support for the dark theme there yet. Therefore I agree that it may indeed be best to design the dark theme from scratch rather than basing it on what we currently have.
Note: See
TracTickets for help on using
tickets.
We don't have a spec for the DevTools panel yet which defines overall design and user experience. It definitely makes sense to have one at some point, I just feel that it's not as critical as other UIs that we still need to add to the spec (e.g. icon popup).
That being said, we can already work on improving our dark theme support for all supported browsers because there's also some improvements we should make for Firefox.
@Jeen Feel free to disagree.