Opened on 02/06/2018 at 11:05:04 PM

Closed on 02/10/2018 at 02:25:32 AM

#6361 closed change (fixed)

Make all strings localizable in the action extension

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: #6261 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29690946/

Description (last modified by dzhang)

Background

For translations, strings need to be available for export. There are a couple problems with the action extension.

  1. Extraneous placeholders are present (i.e. CNN website)
  2. Attributed strings used in the storyboard are not exported for translation.

What to change

  • Remove extraneous placeholders
  • Make attributed strings available for translation

Attachments (0)

Change History (3)

comment:1 Changed on 02/07/2018 at 01:15:52 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 02/07/2018 at 01:16:17 AM by dzhang

  • Description modified (diff)

comment:3 Changed on 02/10/2018 at 02:25:32 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.