Opened on 02/25/2018 at 10:49:43 PM
Closed on 02/26/2018 at 04:40:51 PM
Last modified on 03/16/2018 at 12:41:22 PM
#6417 closed defect (fixed)
empty error message for incorrect custom filters
| Reported by: | mapx | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, mjethani, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
ABP last dev build (FF / chrome) 3.0.2.1975
FF beta / chrome beta
windows 7 / windows 10
Ubuntu 17.10
Chrome 64
Adblock Plus 3.0.2.1975
How to reproduce
Add the custom filter @@||example.com^$first-party or ,###whatever
Observed behaviour
Modal dialog opens displaying only the row number of the incorrect filter, no error message.
Further information
We use Utils.getString() in lib/filterValidation.js to retrieve the error message for the given error reason. However, unlike browser.i18n.getMessage() it returns an empty string instead.
Attachments (1)
Change History (13)
comment:1 Changed on 02/26/2018 at 11:21:24 AM by mapx
- Cc greiner added
comment:2 Changed on 02/26/2018 at 11:22:49 AM by mapx
- Component changed from Platform to User-Interface
comment:3 Changed on 02/26/2018 at 01:14:57 PM by greiner
Changed on 02/26/2018 at 01:34:15 PM by mapx
comment:4 Changed on 02/26/2018 at 01:34:43 PM by mapx
@@||example.com^$first-party
which obviously is not accepted by ABP (windows 7 / windows 10)
see attachment
comment:6 follow-up: ↓ 9 Changed on 02/26/2018 at 01:54:03 PM by greiner
- Component changed from User-Interface to Platform
- Description modified (diff)
Thanks. I was able to reproduce it with this filter and identify what's causing this issue.
comment:7 Changed on 02/26/2018 at 02:53:33 PM by kzar
- Description modified (diff)
- Owner set to kzar
- Priority changed from Unknown to P3
- Ready set
comment:8 Changed on 02/26/2018 at 02:53:44 PM by kzar
- Priority changed from P3 to P2
comment:9 in reply to: ↑ 6 Changed on 02/26/2018 at 03:04:48 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
I don't understand why Utils.getString() was there at all, as far as I can see it's only being used in this one place and as we found out it didn't work there.
comment:10 Changed on 02/26/2018 at 04:40:05 PM by abpbot
A commit referencing this issue has landed:
Issue 6417 - Remove Utils.getString and the last (faulty) use of it
comment:11 Changed on 02/26/2018 at 04:40:51 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 03/16/2018 at 12:41:22 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Line number and error messages are now displayed as expected.
Firefox 53 / Firefox 58 / Windows 7
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7
I wasn't able to reproduce this by adding the filter [ in the custom filter list. The filter is simply not added and no error message is shown (that's because #5549 is not included in this release yet).
Ubuntu 17.10
Chrome 64
Adblock Plus 3.0.2.1975
Which filter did you use to trigger that message?