Opened on 03/14/2018 at 08:28:04 PM

Closed on 03/20/2018 at 04:28:37 AM

#6479 closed change (fixed)

Follow recommendations for eyeo linting

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29722913/

Description

Background

For ​https://github.com/adblockplus/needs-translation, the Javascript code can be adapted to the eyeo Javascript style.

What to change

  • Run eslint with eyeo config and remove warnings/errors.

Attachments (0)

Change History (2)

comment:1 Changed on 03/14/2018 at 09:26:54 PM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/20/2018 at 04:28:37 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.