Opened on 03/16/2018 at 05:32:54 PM
Closed on 03/19/2018 at 05:42:54 PM
Last modified on 05/10/2018 at 11:29:15 AM
#6491 closed change (fixed)
Require Windows build 16299 for Adblock Plus for Microsoft Edge
| Reported by: | agiammarchi | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.1-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | Edge |
| Cc: | greiner, saroyanm, sebastian, oleksandr | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
The new options page is now compatible with Microsoft Edge (#5813), but requires EdgeHTML >=16 (Build 16299). Currently, we still support EdgeHTML 15 (Build 15063). But we decided to bump the minimum Windows version, for the next release, rather than dealing with the issues (e.g. incomplete support of CSS variables) on EdgeHTML 15.
For reference, 85% of users are already on the Windows 10 Fall Creators Update (Build 16299) which includes EdgeHTML 16. Once we release the next version of Adblock Plus for Microsoft Edge, users on older Windows versions, can still keep using/installing the previous version of Adblock Plus.
What to change
Update metadata.edge to require at least Microsoft Edge 41.16299.0.0 and Windows 10.0.16299.0.
Attachments (0)
Change History (9)
comment:2 Changed on 03/16/2018 at 05:58:35 PM by sebastian
- Component changed from Unknown to Platform
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
- Summary changed from Bump MS Edge base version to 16 to Require Windows build 16299 for Adblock Plus for Microsoft Edge
comment:5 Changed on 03/16/2018 at 10:47:55 PM by sebastian
- Owner set to sebastian
comment:6 Changed on 03/16/2018 at 10:48:02 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 03/19/2018 at 05:41:24 PM by abpbot
comment:8 Changed on 03/19/2018 at 05:42:54 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 05/10/2018 at 11:29:15 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Cannot install in Windows 10 Build 10240 but can in Build 16299.248.
A commit referencing this issue has landed:
Issue 6491 - Require Windows build 16299 for Adblock Plus for Microsoft Edge