Opened on 03/20/2018 at 11:42:48 AM

Closed on 08/29/2019 at 05:43:52 PM

#6505 closed change (rejected)

Make use of default function parameters in Core module

Reported by: mjethani Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: erikvold Blocked By:
Blocking: #6445 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29714606/

Description

Background

See #6445.

What to change

Find instances in the code where it would benefit from the use of default function parameters and make the appropriate changes.

Attachments (0)

Change History (3)

comment:1 Changed on 03/20/2018 at 11:49:00 AM by abpbot

A commit referencing this issue has landed:
​Issue 6505 - Make selector parameter in makeSelector optional

comment:2 Changed on 11/15/2018 at 05:27:42 AM by erikvold

  • Cc erikvold added

comment:3 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.