Opened on 03/31/2018 at 12:03:13 AM

Closed on 04/03/2018 at 09:33:18 PM

#6540 closed change (fixed)

Update build settings as recommended by Xcode 9.3

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29737589/

Description

Background

Enables the following recommended compiler warnings:

  • Implicit retain of 'self' within blocks
  • Overriding deprecated Objective-C methods

What to change

Update build settings recommended by Xcode 9.3.

Attachments (0)

Change History (2)

comment:1 Changed on 03/31/2018 at 12:19:11 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/03/2018 at 09:33:18 PM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.