Opened on 04/04/2018 at 04:42:58 PM
Closed on 08/29/2019 at 05:43:52 PM
Last modified on 10/08/2019 at 06:04:37 PM
#6550 closed change (rejected)
Provide ability to hide background image ads
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | Lain_13, mapx, arthur, amrmak, erikvold | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
As mentioned in #756, RU AdList CSS Fixes uses CSS styles to hide ads that are embedded using background images:
Pointer event and background styles are useful to remove stuff like branding. In particular cases when branding is slapped right at BODY or in the div between BODY and content and onclick event is used to handle clicks there. Pointer events will block any reaction on clicks there and background(-image): none will remove the image. Cursor:auto is usually somewhere near to remove that hand cursor if site owner cared to change it to indicate that branding is actually clickable.
Example:
@-moz-document domain("3dnews.ru")
{
#global-wrapper[style*="pointer"]
{
cursor: auto !important;
background-image: none !important;
pointer-events: none !important;
}
}
What to change
Provide filter authors with the ability to hide background images and pointer events.
Attachments (0)
Change History (9)
comment:1 Changed on 04/04/2018 at 04:55:48 PM by mapx
- Cc Lain_13 mapx added
comment:2 Changed on 04/04/2018 at 07:09:29 PM by arthur
- Cc arthur added
comment:3 Changed on 04/04/2018 at 09:31:50 PM by Lain_13
comment:4 Changed on 04/06/2018 at 10:39:05 AM by amrmak
- Cc amrmak added
comment:5 Changed on 04/18/2018 at 09:17:18 AM by jgarcia
- Keywords circumvention added
comment:6 Changed on 04/18/2018 at 10:23:22 AM by jgarcia
- Keywords circumvention removed
comment:7 Changed on 11/15/2018 at 05:29:48 AM by erikvold
- Cc erikvold added
comment:8 Changed on 08/26/2019 at 08:58:04 AM by isabelladom
spam
comment:9 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
I'd like to mention, that pointer-events are kind of a half-measure. There is a downside to it the same as with any other style. It's inheritable. As the result you have to re-enable events at some point with pointer-events:auto!important and that is _also_ inherited and breaks any pointer-events styles down the line if there any.
It would be much better if there'd be a way to apply this only to specific elements on the page without making it inheritable. Not necessarily with a style. Maybe by removing all kinds of click events from an object or something along the line (and applying click-blocking event if it's an A tag).