Dev builds of ABP for Firefox aren't being updated to the latest version

[arthur]

Environment

Mozilla Firefox 59.0.2

How to reproduce

1. Go to ​https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/
2. Install Adblock Plus for Firefox 3.0.2.1997 or Adblock Plus for Firefox 3.0.2.1998
3. Go to about:addons
4. Click the cog wheel and then on "Check for Updates"

Observed behaviour

Firefox doesn't find any updates.

Expected behaviour

Firefox should update to the latest dev build (currently 3.0.2.2002).

Notes

• This was caused by a typo (trailing brace) in ​93c8f5ecd4b.

[tlucas]

I can reproduce the behavior, although this is quiet odd.

When you go to about:debugging#addons and follow Manifest URL in the extension Adblock Plus development build, you see that update_url is set to the correct URL, i.e. https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/updates.json, which (currently) yields the following:

{
  "addons": {
    "devbuild@adblockplus.org": {
      "updates": [
        {
          "version": "3.0.2.2002",
          "update_link": "https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/adblockplusfirefox-3.0.2.2002.xpi" },
          "applications": {
          "gecko": { "strict_min_version": "51.0" }
        }
      ]
    }
  }
}

So - the latest devbuild is listed, but apparently firefox refuses to recognize it?

[tlucas]

Found the error, apparently the content of "updates.json" is not well formed.

[abpbot]

A commit referencing this issue has landed:
​Issue 6560 - fix malformed updates.json