Opened on 04/17/2018 at 10:27:20 PM

Closed on 04/24/2018 at 02:03:29 AM

#6593 closed change (fixed)

Improve and correct use of substituted API values

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29755555/

Description

Background

A variable in the stencil was using the wrong symbol.

Also, according to documentation for Sourcery, environment variable should be escaped with double quotes.

What to change

  1. Fix stencil symbol
  2. Escape environment variables with double quotes

Attachments (0)

Change History (2)

comment:1 Changed on 04/18/2018 at 05:38:21 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/24/2018 at 02:03:29 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.