Opened on 06/01/2018 at 10:41:59 PM
Closed on 06/05/2018 at 08:36:05 PM
Last modified on 01/16/2019 at 01:34:58 PM
#6724 closed defect (fixed)
Build fails due to missing string resources
Reported by: | diegocarloslima | Assignee: | diegocarloslima |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.5.0 |
Module: | Adblock-Browser-for-Android | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Adblock Browser for Android | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by diegocarloslima)
In order to set the default bookmarks, we have previously removed all the original string resources prefixed by bookmarkdefaults_. But now (abb_fennec_59_0_2_merge), there are references for some of them in the UnusedResourcesUtil.java class, causing the build to fail with the following error log:
1:32.69 :app:compileOfficialPhotonDebugJavaWithJavac/Users/dclal/Workspace/adblockbrowser/mobile/android/base/java/org/mozilla/gecko/util/UnusedResourcesUtil.java:80: error: cannot find symbol 1:32.69 R.string.bookmarkdefaults_title_restricted_support, 1:32.69 ^ 1:32.69 symbol: variable bookmarkdefaults_title_restricted_support 1:32.69 location: class string 1:32.70 /Users/dclal/Workspace/adblockbrowser/mobile/android/base/java/org/mozilla/gecko/util/UnusedResourcesUtil.java:81: error: cannot find symbol 1:32.70 R.string.bookmarkdefaults_url_restricted_support, 1:32.70 ^ 1:32.70 symbol: variable bookmarkdefaults_url_restricted_support 1:32.70 location: class string 1:32.70 /Users/dclal/Workspace/adblockbrowser/mobile/android/base/java/org/mozilla/gecko/util/UnusedResourcesUtil.java:82: error: cannot find symbol 1:32.70 R.string.bookmarkdefaults_title_restricted_webmaker, 1:32.70 ^ 1:32.70 symbol: variable bookmarkdefaults_title_restricted_webmaker 1:32.70 location: class string 1:32.70 /Users/dclal/Workspace/adblockbrowser/mobile/android/base/java/org/mozilla/gecko/util/UnusedResourcesUtil.java:83: error: cannot find symbol 1:32.70 R.string.bookmarkdefaults_url_restricted_webmaker, 1:32.70 ^ 1:32.70 symbol: variable bookmarkdefaults_url_restricted_webmaker 1:32.70 location: class string 1:33.26 Note: Some input files use or override a deprecated API. 1:33.26 Note: Recompile with -Xlint:deprecation for details. 1:33.26 4 errors 1:33.26 FAILED
We need remove those references in order to fix this build issue.
Hints for testers
This is a build issue
Attachments (0)
Change History (5)
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6724 - Build fails due to missing string resources