Opened on 06/13/2018 at 09:11:06 AM
Closed on 06/15/2018 at 05:02:10 PM
Last modified on 07/05/2018 at 01:09:15 PM
#6746 closed defect (fixed)
Element hiding filter applied although it shouldn't
| Reported by: | arthur | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.2-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian, Ross | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
- Chrome 67.0.3396.87 (Official Build) (64-bit) or 69.0.3457.0 (Official Build) canary (64-bit)
- ABP dev build 3.1.0.2065
- EasyList Germany+EasyList
- No AA
How to reproduce
Observed behaviour
No self-promotion banners (served from tpc.googlesyndication.com) appearing.
Expected behaviour
Self-promo banners should show since they are specifically whitelisted in EasyList Germany.
Notes
If you check the ABP dev panel, you'll notice ##.img_ad is still applied although whitelisted via notebooksbilliger.de#@#.img_ad in EasyList Germany. Even adding @@||notebooksbilliger.de^$elemhide doesn't help here. It seems ABP cannot recognize the hiding filter is applied on this domain, there simply is no docoment source in the ABP dev panel listed for it.
Took this issue from this comment. The actual resources seem to load correctly now.
This seems to be another regression caused by our change to update the page frame structure on browser.webNavigation.onCommitted instead of browser.webNavigation.onBeforeNavigate.
Attachments (0)
Change History (6)
comment:1 Changed on 06/15/2018 at 10:15:23 AM by kzar
- Cc Ross added
- Description modified (diff)
- Milestone set to Adblock-Plus-3.2-for-Chrome-Opera-Firefox
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 06/15/2018 at 10:23:37 AM by kzar
- Owner set to kzar
comment:3 Changed on 06/15/2018 at 10:26:43 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 06/15/2018 at 05:01:10 PM by abpbot
A commit referencing this issue has landed:
Issue 6746 - Update frame structure for about:srcdoc frames earlier
comment:5 Changed on 06/15/2018 at 05:02:10 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 07/05/2018 at 01:09:15 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. The self promotion banners now show.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
Same problem as #6692, except this time the frames are "about:srcdoc" instead of "about:blank".