Opened on 06/20/2018 at 09:42:36 AM
Closed on 07/18/2018 at 06:08:21 PM
#6753 closed change (duplicate)
Update adblockplusui/adblockpluscore dependency to 9a652397b9af/0cf4e33d288b
| Reported by: | wspee | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-3.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | greiner, sebastian, mjethani | Blocked By: | #6559, #6739 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
In #6559 FilterStorage.knownSubscriptions was changed to a Map object which necessitates #6739 to ensure the user interface stays compatible. To ensure a working extension we (Sebastian/Winsley) plan to update the abpui/abpcore dependencies together, without further ui changes (there will be a separate ui dependency update at the end of the 3.3 cycle to land the latest ui changes), right after the release of ABP 3.2.
What to change
Update adblockplusui dependecy to hg:9a652397b9af git:2fe1f424
| Ticket | Summary | Component |
|---|---|---|
| #6739 | Update code to work with FilterStorage.knownSubscriptions as a Map object | User-Interface |
Update adblockpluscore dependency to hg:0cf4e33d288b git:b4e73b3
Attachments (0)
Change History (8)
comment:1 Changed on 06/20/2018 at 09:45:03 AM by wspee
comment:2 Changed on 06/20/2018 at 10:59:22 AM by mjethani
@wspee I would just update the dependency to 0cf4e33d288b. In #6559 I have mentioned the changes so far, I think #6739 should be sufficient.
comment:3 Changed on 06/20/2018 at 12:26:28 PM by wspee
- Description modified (diff)
@Manish Ok, thanks. I have updated the description to update the core dependency to 0cf4e33d288b instead.
comment:4 Changed on 07/18/2018 at 12:35:36 PM by greiner
- Description modified (diff)
Since we released version 3.2 of the extension yesterday I've now pushed the necessary FilterStorage.knownSubscriptions changes to adblockplusui and added the commit hashes to the ticket description accordingly.
comment:5 Changed on 07/18/2018 at 01:21:58 PM by mjethani
- Summary changed from Update adblockplusui/adblockpluscore dependency to TBA/212fe705ab82 to Update adblockplusui/adblockpluscore dependency to 9a652397b9af/0cf4e33d288b
comment:6 follow-up: ↓ 7 Changed on 07/18/2018 at 01:23:42 PM by mjethani
We might want to wait for Snippets, it's almost done.
@Sebastian/@Manish
adblockpluscore:212fe705ab82 is needed for #6739 to work but I don't know if 212fe705ab82 is sufficient in it self and/or further platform changes are needed for compatibility with the latest core, so feel free to update the core dependency/description as needed.