Opened on 07/31/2018 at 08:25:15 PM
Closed on 07/31/2018 at 09:03:38 PM
Last modified on 08/16/2018 at 01:33:51 PM
#6823 closed change (fixed)
Remove unnecessary usage of the /u flag in regular expressions
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | kzar | Blocked By: | |
| Blocking: | #6821 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
See #6821 for the background.
In a couple of places we are using the /u flag in regular expressions where it is not really needed, as it does not affect \s (whitespace matching). Since Chrome 49 does not support the /u flag, we should remove it.
What to change
In lib/snippets.js and lib/common.js remove the unnecessary usage of the /u flag in the two places where it is being used.
Hints for testers
Same as #6781 and #6619, but focus on whitespace in the snippet filter and the CSS selector respectively.
Attachments (0)
Change History (8)
comment:1 Changed on 07/31/2018 at 08:33:23 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 07/31/2018 at 09:02:16 PM by abpbot
comment:5 Changed on 07/31/2018 at 09:03:38 PM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 07/31/2018 at 09:09:01 PM by mjethani
- Description modified (diff)
- Summary changed from Remove unnecessary usage of the u flag in regular expressions to Remove unnecessary usage of the /u flag in regular expressions
comment:7 Changed on 08/02/2018 at 09:02:34 AM by abpbot
A commit referencing this issue has landed:
Issue 6823 - Remove unnecessary usage of /u flag
comment:8 Changed on 08/16/2018 at 01:33:51 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Extension works in Chrome 49 again. The snippet and selector changes also work as expected.
ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10
A commit referencing this issue has landed:
Issue 6823 - Remove unnecessary usage of /u flag