Opened on 08/31/2018 at 08:54:45 AM
Closed on 09/07/2018 at 03:36:47 PM
#6913 closed defect (fixed)
Some test cases fail on Edge
Reported by: | geo | Assignee: | geo |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
Module: | Platform | Keywords: | |
Cc: | sebastian, kzar | Blocked By: | |
Blocking: | Platform: | Edge | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
Microsoft Edge 42.17134.1.0
How to reproduce
- Build the extension.
- Check the qunit test page.
Observed behaviour
The following tests fail:
URL/host tools: Extracting hostname from URL with auth credentials
and
URL/host tools: Extracting hostname from frame with punycode
Expected behaviour
Tests should pass just like on Chrome.
Attachments (1)
Change History (7)
Changed on 08/31/2018 at 08:55:04 AM by geo
comment:1 Changed on 08/31/2018 at 03:56:12 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 09/05/2018 at 10:50:35 AM by geo
Somebody else reported the first bug a while ago, and I've reported the second one.
Here are the links:
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8004284/ -> this is for credentials
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18861990/ -> this is for punycode
comment:3 Changed on 09/05/2018 at 11:02:08 AM by geo
- Owner set to geo
comment:5 Changed on 09/07/2018 at 03:36:22 PM by abpbot
A commit referencing this issue has landed:
Issue 6913 - Ignore test cases failing due to bugs in Microsoft Edge
comment:6 Changed on 09/07/2018 at 03:36:47 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from new to closed
These test failures reveal two bugs in Microsoft Edge:
Both is non-standard behavior, no other major browser is implementing. Can you please file those bugs with Microsoft?
Furthermore, the "Extracting hostname from URL" test is currently testing the browser's URL object rather than any of our APIs. So this test should IMO be removed. However, we might want to cover the case with the credentials as part of the "Extracting hostname from frame" test instead.
Then for the time being, let's skip the cases on Microsoft Edge that are subject to the above bugs.