Opened on 06/21/2014 at 01:19:16 PM

Last modified on 06/01/2015 at 09:18:50 PM

#693 new defect

Sponsored Ads on Facebook (in stream sponsored posts)

Reported by: Syntax Assignee: Mailkov
Priority: P3 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by oleksandr)


Windows 8.1 Update 1 64-bit, IE 11.0.9600.17126, Adblock Plus for Internet Explorer 1.2.636 and Easylist.

Observed behaviour

In-stream sponsored posts are not hidden. But the images from those posts are blocked.

Expected behaviour

Sponsored posts should be blocked and hidden.

Attachments (0)

Change History (13)

comment:1 Changed on 06/21/2014 at 06:36:49 PM by mapx

  • Cc oleksandr added
  • Priority changed from Unknown to P3

comment:2 Changed on 06/23/2014 at 07:20:59 AM by mapx

another user wrote:

Yeah, that's the exact behaviour I experienced with ver: 1.1 when it was bugged for me.
The good news is, it can be un-bugged.

Un-install all add-ons (un-install, not disable).
Install ABP & test functionality.

That was all I needed to get ABP working properly.
I then re-installed some of the add-ons I had removed, testing ABP after each install till I found the add-on causing the bug.

Once I had identified the problem add-on I had to repeat the whole process to get ABP working again.
I dumped the bugging add-on (don't miss it) & ABP has worked properly since then. I very, very rarely see any ads or pop ups & when I do they are usually soon corrected with an auto pattern file update.

comment:3 Changed on 06/23/2014 at 07:58:59 AM by philll

  • Keywords ie_devbuild_1.2 added

comment:4 Changed on 07/09/2014 at 12:36:01 PM by philll

  • Platform set to Internet Explorer

comment:5 Changed on 12/03/2014 at 01:41:27 PM by oleksandr

  • Description modified (diff)
  • Keywords ie_devbuild_1.2 removed
  • Ready set
  • Summary changed from Sponsored Ads on Facebook (on the right side) to Sponsored Ads on Facebook (in stream sponsored posts)

comment:6 Changed on 05/22/2015 at 10:10:06 AM by Mailkov

I would like to work on this... Can you assign it to me?

comment:7 Changed on 05/22/2015 at 11:04:22 AM by oleksandr

  • Owner set to Mailkov

comment:8 Changed on 05/29/2015 at 07:23:22 AM by Mailkov[id^"topnews_main_stream_"] div[data-ft*="\"ei\":\""]

is the filter that seems do not working.

Now I'm investigating on this defect.

Errors on debug_result.txt :

08:33:33.252 - ===========================================================================================================================================================================================
08:33:33.254 -
08:33:33.256 - ===========================================================================================================================================================================================
08:33:48.551 - Error loading hide filter: div[id^="substream_"] .userContentWrapper > ._1ifo
08:33:48.574 - Error loading hide filter: div[id^="substream_"] div[data-ft*="\"ei\":\""]
08:33:48.599 - Error loading hide filter: div[id^="topnews_main_stream_"] div[data-ft*="\"ei\":\""]
Last edited on 05/29/2015 at 08:48:41 AM by Mailkov

comment:9 Changed on 05/29/2015 at 11:49:48 AM by Mailkov

The problem is in CPluginFilter::AddFilterElementHide and CFilterElementHide::CFilterElementHide.

Code problem is here:

while (!filterString.IsEmpty())
    if (filterString.GetAt(0) != chAttrStart)
      DEBUG_FILTER("Filter::Error parsing selector:" + filterText + " (more data)");
      throw std::runtime_error(CStringA("Filter::Error parsing selector:" + filterText + " (more data)").GetString());

because, first time of loop

filterString = '[id^"topnews_main_stream_"] div[data-ft*="\"ei\":\""]'

the second time

 filterString = ' div[data-ft*="\"ei\":\""]'

so filterStringGetAt(0)=' ' and chAttrStart='[' and so DEBUG_FILTER starts

Last edited on 05/29/2015 at 11:56:05 AM by Mailkov

comment:10 Changed on 05/29/2015 at 11:57:58 AM by Mailkov

The easier way to solve this defect is to substitute the filter for simpler one.

comment:11 Changed on 05/29/2015 at 12:16:07 PM by Mailkov

I spoke with Arthur: it is not possible to change the filter ...
So the only solution is to support it.

Last edited on 05/29/2015 at 12:18:19 PM by Mailkov

comment:12 Changed on 05/29/2015 at 05:23:50 PM by Mailkov

I tried this filter:[data-ft*="\"ei\":\""]

and it works and it have the same result of[id^"topnews_main_stream_"] div[data-ft*="\"ei\":\""]

Can we divide this into two filter? example:[id^"topnews_main_stream_"]


oleksandr, How about this?

Last edited on 05/29/2015 at 05:29:31 PM by Mailkov

comment:13 Changed on 06/01/2015 at 09:18:50 PM by Mailkov

pull request
this works adding the filter[data-ft*="\"ei\":\""]

Add Comment

Modify Ticket

Change Properties
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Mailkov.
Next status will be 'reviewing'.
Note: See TracTickets for help on using tickets.