Opened on 09/17/2018 at 06:43:31 AM
Closed on 10/11/2018 at 10:01:49 AM
#6958 closed change (fixed)
Lower minSdk required for -settings module
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | sergz, diegocarloslima, jwangenheim | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Each libadblockplus-android module has it's own limitations for android min sdk version.
For -settings module we have 21 currently:
https://github.com/adblockplus/libadblockplus-android/blob/master/adblock-android-settings/build.gradle#L9
Since it's not actually limited by 21 and since some partners can desire lower limitation we can lower it to 16 at least.
What to change
min sdk version in build.gradle and AndroidManifest.xml
Attachments (0)
Change History (4)
comment:1 Changed on 09/17/2018 at 06:51:09 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/11/2018 at 09:19:13 AM by abpbot
comment:3 Changed on 10/11/2018 at 10:01:43 AM by asmirnov
published to bintray too:
https://bintray.com/adblockplus/maven/adblock-android-settings/3.1
comment:4 Changed on 10/11/2018 at 10:01:49 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6958 - Lower minSdk required for -settings module