Opened on 09/21/2018 at 08:04:03 AM
Closed on 12/18/2018 at 09:01:30 AM
#6971 closed change (fixed)
Update regular expressions for resource type detection
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | diegocarloslima, jwangenheim, sergz | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29920555/ |
||
Description
Background
Regular expressions are used to detect resource type in AdblockWebView:
https://github.com/adblockplus/libadblockplus-android/blob/master/adblock-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java#L92
We've updated them in AdblockChromium project
(as sometime we don't have information from Chromium and have to detect it with regexps):
https://github.com/adblockplus/chromium/pull/8/files#diff-88e0df9e94154fb3afe8d79ed070784fR90
What to change
Update regexps.
Attachments (0)
Change History (7)
comment:1 Changed on 09/21/2018 at 08:04:22 AM by asmirnov
- Summary changed from Update regex to Update regular expressions for resource type detection
comment:2 Changed on 10/23/2018 at 11:05:53 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 10/30/2018 at 07:50:34 AM by asmirnov
- Blocking 5140 added
comment:5 Changed on 10/30/2018 at 10:00:14 AM by asmirnov
- Blocking 5140 removed
comment:6 Changed on 10/30/2018 at 10:00:27 AM by asmirnov
comment:7 Changed on 12/18/2018 at 09:01:30 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Depends on https://gitlab.com/eyeo/adblockplus/libadblockplus-android/merge_requests/6