Opened on 09/26/2018 at 01:53:54 AM

Closed on 09/26/2018 at 12:25:21 PM

Last modified on 02/07/2019 at 03:23:41 AM

#6987 closed defect (fixed)

Executing individual test files no longer works

Reported by: mjethani Assignee: hfiguiere
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: hfiguiere, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29891693/

Description

Environment

adblockpluscore changeset 05385aac7501

How to reproduce

  1. Run npm test test/matcher.js from the command line

Observed behaviour

You get this error:

runBrowserTests(runnerProcesses).then(() =>
                                ^

TypeError: Cannot read property 'then' of undefined

Expected behaviour

The test file test/matcher.js should run as it did before recent changes.

Attachments (0)

Change History (7)

comment:1 Changed on 09/26/2018 at 02:48:30 AM by hfiguiere

I have a fix for that. Please stand by.

comment:2 Changed on 09/26/2018 at 02:51:22 AM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/26/2018 at 02:51:33 AM by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed on 09/26/2018 at 10:34:19 AM by mjethani

  • Cc sebastian added
  • Component changed from Core to Automation

comment:5 Changed on 09/26/2018 at 12:24:45 PM by abpbot

A commit referencing this issue has landed:
Issue 6987 - Fix regression preventing running individual tests

comment:6 Changed on 09/26/2018 at 12:25:21 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 02/07/2019 at 03:23:41 AM by abpbot

A commit referencing this issue has landed:
Issue 6987 - Fix regression preventing running individual tests

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
 
Note: See TracTickets for help on using tickets.