Opened on 09/27/2018 at 03:05:53 PM
Closed on 10/25/2018 at 08:45:52 AM
#6996 closed defect (fixed)
Mercurial 4.7 breaks use of revision number for `--change ` argument in hgreview.py
| Reported by: | jsonesen | Assignee: | kvas |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | kvas, hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29897571 |
||
Description
Environment
Mecurial 4.7 Linux(Debian)
condingtools/hgreview.py (:tip)
How to reproduce
Upload change set using commit number passed to -c in hgreview
Observed behaviour
Stack trace returned
mercurial.error.ProgrammingError: unsupported changeid '945' of type <type 'str'>
Expected behaviour
Hg review should accept changeid with the change argument. Tried changing the parsing of the argument in hgreview.py to no avail, ended up reverting to mercurial 4.6 for the time being.
Attachments (0)
Change History (10)
comment:1 Changed on 09/28/2018 at 04:44:10 PM by hfiguiere
comment:2 Changed on 09/28/2018 at 04:44:35 PM by hfiguiere
- Cc hfiguiere added
comment:3 Changed on 10/01/2018 at 03:38:23 PM by kvas
- Component changed from Unknown to Automation
- Owner set to kvas
- Review URL(s) modified (diff)
comment:4 Changed on 10/01/2018 at 03:38:32 PM by kvas
- Status changed from new to reviewing
comment:5 Changed on 10/05/2018 at 11:06:27 AM by abpbot
A commit referencing this issue has landed:
Issue 6996 - Fix -c option
comment:6 Changed on 10/05/2018 at 11:07:28 AM by kvas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 10/24/2018 at 02:15:06 PM by kvas
- Resolution fixed deleted
- Review URL(s) modified (diff)
- Status changed from closed to reopened
comment:8 Changed on 10/24/2018 at 02:15:20 PM by kvas
- Status changed from reopened to reviewing
comment:9 Changed on 10/25/2018 at 08:44:48 AM by abpbot
A commit referencing this issue has landed:
Fixes 6996 - Also fix -c when -t is not present
comment:10 Changed on 10/25/2018 at 08:45:52 AM by kvas
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I noticed that too. I usually use -c . instead as a workaround (with the proper hg update prior to it.