Opened on 10/02/2018 at 09:21:38 AM

Closed on 10/02/2018 at 01:38:24 PM

Last modified on 10/24/2018 at 09:29:00 AM

#7010 closed change (fixed)

Update subscriptions.xml to include IndianList filter list

Reported by: arthur Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: hfiguiere Blocked By:
Blocking: #7012 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29898560/

Description (last modified by hfiguiere)

Background

There is a recommended filter list for Indian users now (​002e18144b9e).

What to change

Update and regenerate subscriptions.xml to include this new filter list subscription.

Hint for testers

  • Verify that there is an appropriate entry when selecting "Add Language" in the UI.

Attachments (0)

Change History (10)

comment:1 follow-up: Changed on 10/02/2018 at 09:22:44 AM by arthur

Could you file and do the dependecy update after that? I checked with Sebastian and he is fine with it to land in 3.4 still.

comment:2 Changed on 10/02/2018 at 12:49:16 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/02/2018 at 01:13:09 PM by hfiguiere

  • Blocking 7012 added

comment:4 in reply to: ↑ 1 Changed on 10/02/2018 at 01:14:20 PM by hfiguiere

Replying to arthur:

Could you file and do the dependecy update after that? I checked with Sebastian and he is fine with it to land in 3.4 still.

Dependency update filed as #7012

comment:5 Changed on 10/02/2018 at 01:14:34 PM by hfiguiere

  • Owner set to hfiguiere

comment:6 Changed on 10/02/2018 at 01:20:51 PM by hfiguiere

  • Description modified (diff)

comment:7 Changed on 10/02/2018 at 01:35:16 PM by abpbot

A commit referencing this issue has landed:
​Issue 7010 - Added IndianList filter list to subscriptions.xml

comment:8 Changed on 10/02/2018 at 01:38:24 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 10/02/2018 at 03:13:13 PM by abpbot

A commit referencing this issue has landed:
​Issue 7010 - Added IndianList filter list to subscriptions.xml

comment:10 Changed on 10/24/2018 at 09:29:00 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Indian filter list selectable from language UI.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.