Opened on 10/12/2018 at 10:09:17 AM

Closed on 09/17/2019 at 12:34:45 PM

#7039 closed change (fixed)

[XTM Integration] Make parameter naming consistent with the API docs

Reported by: atudor Assignee: atudor
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: #6942 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29969555/

Description

Background

There are two inconsistencies when it comes to the parameters of the XTM integration script:

  1. Username instead of Client name when generating the authentication token.
  2. --client-id instead of --customer-id when creating a new project.

What to change

Change the two parameters above and adapt all the corresponding tests/ functions.

Attachments (0)

Change History (3)

comment:1 Changed on 12/28/2018 at 02:52:54 PM by atudor

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/17/2019 at 12:34:22 PM by abpbot

A commit referencing this issue has landed:
​Issue 7039 - Make parameter naming consistent with the API docs

comment:3 Changed on 09/17/2019 at 12:34:45 PM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from atudor.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.