Opened on 10/31/2018 at 01:32:41 AM

Closed on 01/28/2019 at 02:33:39 PM

Last modified on 02/07/2019 at 03:23:51 AM

#7085 closed defect (fixed)

Update adblockpluscore dependency version of eslint-config-eyeo to latest

Reported by: erikvold Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29991555/

Description

The eslint-config-eyeo is on version 2.1.0 now and we are using version 1.0.4 for our adblockpluscore repo.

As a result issues like Issue #7044 are blocking Issue #6833.

We need to update the version of eslint-config-eyeo which adblockpluscore depends on.

Attachments (0)

Change History (7)

comment:1 Changed on 10/31/2018 at 01:33:05 AM by erikvold

  • Blocking 6833 added

comment:2 Changed on 10/31/2018 at 10:05:13 PM by sebastian

  • Blocking 6833 removed

comment:3 Changed on 01/28/2019 at 01:33:09 PM by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed on 01/28/2019 at 01:36:14 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 01/28/2019 at 02:31:48 PM by abpbot

A commit referencing this issue has landed:
​Issue 7085 - Use newer eslint-config-eyeo and eslint

comment:6 Changed on 01/28/2019 at 02:33:39 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 02/07/2019 at 03:23:51 AM by abpbot

A commit referencing this issue has landed:
​Issue 7085 - Use newer eslint-config-eyeo and eslint

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.