Opened on 11/15/2018 at 01:37:26 AM
Closed on 08/29/2019 at 05:43:52 PM
#7124 closed change (rejected)
Use Retry-After HTTP header for filter list download retry attempts
| Reported by: | erikvold | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by erikvold)
It seems to me like we should be using the Retry-After header both server side and in adblockpluscore for filter list downloads, when a retry or redirect is performed.
At the moment we ignore this header and simply prevent a retry for 24hrs.
Also we have some inserted randomness to the expiration in order to spread out server load, but I think this would be better handled with the Retry-After HTTP header so that the server can better control the traffic.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After
Attachments (0)
Change History (3)
comment:2 Changed on 11/15/2018 at 02:56:24 AM by erikvold
- Description modified (diff)
- Summary changed from Use Retry-After HTTP Header for filter list download retry attempts to Use Retry-After HTTP header for filter list download retry attempts
comment:3 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.