Opened on 01/04/2019 at 11:32:49 AM

Closed on 01/07/2019 at 10:30:15 AM

#7192 closed change (fixed)

Remove hardcoded qunit/common.js from webpack qunit/tests.js bundle

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: tlucas, sebastian Blocked By:
Blocking: #7191 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/abpui/buildtools/merge_requests/1
​https://codereview.adblockplus.org/29973555/

Description

Background

We no longer need the adblockpluschrome/qunit/common.js file, but its path is hardcoded in buildtools/packagerChrome.py.

What to change

Modify create_bundles in packagerChrome.py so that qunit/common.js is no longer hardcoded.

Attachments (0)

Change History (7)

comment:1 Changed on 01/04/2019 at 11:53:33 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/04/2019 at 11:54:42 AM by kzar

  • Blocking 7191 removed

comment:3 Changed on 01/04/2019 at 03:29:57 PM by kzar

  • Blocking 7191 added

comment:4 Changed on 01/04/2019 at 03:30:36 PM by kzar

  • Review URL(s) modified (diff)

comment:5 Changed on 01/04/2019 at 09:51:47 PM by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:6 Changed on 01/07/2019 at 10:25:45 AM by abpbot

A commit referencing this issue has landed:
​Issue 7192 - Remove unused qunit/common.js file from webpack bundle

comment:7 Changed on 01/07/2019 at 10:30:15 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.