Opened on 01/08/2019 at 01:26:19 PM
Closed on 03/07/2019 at 01:46:33 PM
Last modified on 08/26/2019 at 02:27:14 PM
#7197 closed defect (fixed)
Options page displays General tab when submitting whitelist entry in Edge
| Reported by: | Ross | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, kzar, geo, greiner | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/235 |
||
Description (last modified by greiner)
Environment
ABP 0.9.11.2206 (Devbuild)
Edge 42.17134.1.0 / EdgeHTML 17.17134
NOT a regression compared to 0.9.11 (Release)
How to reproduce
- Select [ABP Icon] > [Cog].
- Select [Whitelist].
- Add something to the whitelist (anything).
Observed behaviour
The options page is displays the [General] tab again on submission of a whitelist entry. Checking the [Whitelist] tab shows the entry was added correctly.
Expected behaviour
The options page to not change tab when adding a whitelist entry (to match Chrome and Firefox).
What to change
Explicitly call Event.preventDefault() when executing an action in the desktop options page.
See also ui#347.
Hints for testers
This change affects all keyboard and mouse interactions on the desktop options page.
Attachments (0)
Change History (8)
comment:1 Changed on 03/05/2019 at 01:02:49 PM by greiner
- Cc greiner added
- Component changed from Unknown to User-Interface
comment:2 Changed on 03/05/2019 at 01:20:59 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
I found that we implicitly cancel the event by disabling the submit button rather than by explicitly calling preventDefault(). Edge doesn't cancel the event on the former though which is what's causing the difference in behavior.
comment:3 Changed on 03/05/2019 at 01:49:05 PM by greiner
- Description modified (diff)
- Owner set to greiner
comment:4 Changed on 03/05/2019 at 02:00:11 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 03/07/2019 at 01:46:33 PM by greiner
- Description modified (diff)
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 06/19/2019 at 09:28:07 AM by Ross
This is occurring again in the 3.6 dev builds for Edge. Should I open a ticket on GitLab?
ABP 0.9.15.2335
Edge 44.17763.1.0
comment:7 Changed on 06/19/2019 at 09:33:07 AM by Ross
Already on GL here: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/347
comment:8 Changed on 08/26/2019 at 02:27:14 PM by abpbot
A commit referencing this issue has landed:
Issue 7197 - Fixed: Explicitly prevent form submission when adding domain to whitelist
That sounds like we're not cancelling the "submit" event when submitting the form and thereby causing the frame content to be reloaded. I have yet to verify that assumption though.