Opened on 03/19/2019 at 10:20:50 AM
Closed on 03/21/2019 at 08:55:48 PM
Last modified on 07/25/2019 at 07:56:40 PM
#7380 closed change (fixed)
Remove references to onShutdown
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sergz, sebastian | Blocked By: | |
| Blocking: | #5702 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/35 |
||
Description (last modified by mjethani)
Background
The onShutdown global appears to be based on some legacy Gecko APIs (#5702). Its purpose mainly is to stop the scheduled syncing of filter lists. In the WebExt version of Adblock Plus, it appears unnecessary and is in fact a no-op.
Along with this global, the cancel method of the Downloader object can also be removed.
What to change
Remove all references to onShutdown global. Also remove the cancel method of the Downloader object as it would no longer be useful.
Integration notes
In adblockpluschrome, in lib/compat.js, remove the onShutdown object.
Hints for testers
Same as #7376.
Attachments (0)
Change History (8)
comment:1 Changed on 03/19/2019 at 10:32:42 AM by mjethani
- Description modified (diff)
- Owner set to mjethani
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 03/19/2019 at 10:33:09 AM by mjethani
- Cc sergz sebastian added
- Component changed from Unknown to Core
comment:3 Changed on 03/19/2019 at 10:37:14 AM by mjethani
- Blocking 5702 added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/19/2019 at 10:38:05 AM by mjethani
comment:5 Changed on 03/21/2019 at 06:32:32 PM by abpbot
A commit referencing this issue has landed:
Issue 7380 - Remove references to onShutdown
comment:6 Changed on 03/21/2019 at 08:55:48 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 07/25/2019 at 07:56:40 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as described.
ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809
ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2
@sergz I hope libadblockplus does not rely on the global onShutdown object in any way, but if it does then let me know.