Opened on 03/20/2019 at 05:14:24 PM

Closed on 03/20/2019 at 07:55:26 PM

Last modified on 04/02/2019 at 01:30:41 PM

#7388 closed change (fixed)

Update adblockpluscore dependency to hg:0176a2d007e1 git:ba878ce

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.5.1-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/30030574/

Description (last modified by sebastian)

Background

We plan a new snippets/hotfix release: 3.5.1.

Here is the list of changes:

  • Issue #7294 - Implement strip-fetch-query-parameter snippet
  • Issue #7294 - Pass necessary functions to strip-fetch-query-parameter
  • Issue #7356 - Allow wrapping of function properties in snippets
  • Issue #7236 - Handle sub properties in abort-on-property snippets

What to change

Update adblockpluscore dependency to hg:0176a2d007e1 git:ba878ce.

Attachments (0)

Change History (7)

comment:1 Changed on 03/20/2019 at 05:30:11 PM by hfiguiere

  • Description modified (diff)

comment:2 Changed on 03/20/2019 at 06:22:44 PM by hfiguiere

  • Review URL(s) modified (diff)

comment:3 Changed on 03/20/2019 at 06:35:03 PM by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed on 03/20/2019 at 07:52:30 PM by abpbot

A commit referencing this issue has landed:
​Issue 7388 - Update adblockpluscore dependency to hg:0176a2d007e1 git:ba878ce

comment:5 Changed on 03/20/2019 at 07:55:26 PM by hfiguiere

  • Milestone set to Adblock-Plus-3.5.1-for-Chrome-Opera-Firefox
  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed on 03/21/2019 at 12:03:03 AM by sebastian

  • Description modified (diff)

comment:7 Changed on 04/02/2019 at 01:30:41 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. These changes are working in the browsers below.

I could not make this work on Edge (which is probably the same issue as #7409) or in Firefox Mobile (which is probably the same issue as #7410).

ABP 2.5.0.2284
Chrome 73.0.3683.86 / Windows 10
Chrome 49.0.2623.75 / Windows 10
Firefox 65.0.1 / Windows 10
Firefox 51.0 / Windows 10
Opera 58.0.3135.118 / Windows 10
Opera 36.0.2130.80 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.