Opened on 03/22/2019 at 09:25:44 AM

Closed on 08/29/2019 at 05:43:52 PM

#7393 closed change (rejected)

Do error handling for fallback URL

Reported by: mjethani Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: hfiguiere, jsonesen, kzar, sebastian, greiner, sergz, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mjethani)

Background

Currently there is no error handling for the fallback URL (see ​code in lib/synchronizer.js). It always assumes that the request succeeds. If the request fails, it should be handled. Additionally, there should be some tests for this.

What to change

To be determined.

Notes

We appear not to have any tests for the fallback URL feature (see ticket:7376#comment:15). We should add tests.

Attachments (0)

Change History (4)

comment:1 Changed on 03/22/2019 at 09:28:15 AM by mjethani

  • Cc hfiguiere jsonesen kzar sebastian greiner sergz added

comment:2 Changed on 03/22/2019 at 09:37:22 AM by mjethani

  • Description modified (diff)

comment:3 Changed on 03/22/2019 at 09:37:54 AM by mjethani

  • Cc Ross added

comment:4 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.