Opened on 03/28/2019 at 12:58:04 PM

Closed on 04/24/2019 at 03:42:35 PM

#7416 closed change (fixed)

Remove string used for window.confirm notifications

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #7408
Blocking: #7431 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/269

Description

Background

We're removing usage of window.confirm() for notifications (see #7408) so we no longer need the string that's shown in the prompt.

What to change

Remove "notification_with_buttons" translatable string.

Attachments (0)

Change History (4)

comment:1 Changed on 04/02/2019 at 02:16:30 PM by greiner

  • Blocking 7431 added

comment:2 Changed on 04/24/2019 at 12:06:06 PM by greiner

  • Owner set to greiner

comment:3 Changed on 04/24/2019 at 12:08:30 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/24/2019 at 03:42:35 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Done: ​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/cbf819453b13eef5aa9011f6f706e413653f1e0b

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.