Opened on 04/07/2019 at 06:32:15 PM

Closed on 04/07/2019 at 06:51:13 PM

Last modified on 04/07/2019 at 06:54:46 PM

#7445 closed change (rejected)

Implement faster parsing of generic element hiding filters

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: hfiguiere Blocked By:
Blocking: #7000 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mjethani)

Background

The regular expression used to parse content filters is currently /^([^/*|@"!]*?)#([@?$])?#(.+)$/. By this definition, if a filter starts with ##, the rest of the text is always the CSS selector. In EasyList ~20,000 out of ~75,000 lines start with ##.

We can skip the regular expression for this special and very common case.

Resolution

After some investigation, there appears to be no benefit of making this change.

Attachments (0)

Change History (3)

comment:1 Changed on 04/07/2019 at 06:32:45 PM by mjethani

  • Blocking 7000 added

comment:2 Changed on 04/07/2019 at 06:51:13 PM by mjethani

  • Description modified (diff)
  • Resolution set to rejected
  • Status changed from new to closed

comment:3 Changed on 04/07/2019 at 06:54:46 PM by mjethani

  • Cc hfiguiere added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.