Opened on 07/09/2014 at 03:39:39 PM

Closed on 07/10/2014 at 07:41:05 AM

Last modified on 07/15/2014 at 05:00:32 PM

#764 closed defect (fixed)

Adblock Warning opt in message isn't triggered

Reported by: arthur Assignee: saroyanm
Priority: P2 Milestone: Adblock-Plus-2.6.4-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #301 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



Firefox 30
Adblock Plus 2.6.3
Windows 8.1 Pro x64 Update 1

How to reproduce

  1. Create a new Firefox profile
  2. Install Adblock Plus 2.6.3
  3. Go to a site that should trigger the Adblock Warning message like

Observed behaviour

The opt in message for the Adblock Warning Removal List doesn't appear.

Expected behaviour

It should appear when visiting the website.

Attachments (0)

Change History (6)

comment:1 Changed on 07/09/2014 at 05:33:21 PM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 07/09/2014 at 06:44:44 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/10/2014 at 07:41:05 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 07/15/2014 at 07:55:50 AM by saroyanm

The issue persisted for three month:
Here is the revision that caused the issue:

comment:5 Changed on 07/15/2014 at 10:14:38 AM by trev

  • Blocking 301 added

Manvel's investigation shows that this issue is a regression from #301. Apparently, a for loop will allow looping over null whereas a for..of loop won't.

comment:6 Changed on 07/15/2014 at 05:00:32 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.