Opened on 07/11/2014 at 02:32:42 PM

Closed on 11/21/2016 at 10:06:49 AM

#769 closed change (fixed)

Replace auto_ptr by unique_ptr

Reported by: trev Assignee: sergz
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By: #768
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



We currently use std:auto_ptr in a few places in libadblockplus which has some shortcomings:

  • Deprecated due to bad copy semantics.
  • Cannot deal with arrays.
  • Destructor cannot be redefined.

What to change

Switch to std:unique_ptr once we switch to compatible standard libraries on all platforms.

Attachments (0)

Change History (5)

comment:1 Changed on 05/20/2015 at 11:39:02 AM by Mailkov

Hi, I would like to work on this, when the issue 768 will be closed.

Last edited on 05/20/2015 at 11:42:31 AM by Mailkov

comment:2 Changed on 11/03/2016 at 01:05:50 PM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Tester set to Unknown

comment:3 Changed on 11/03/2016 at 01:06:19 PM by sergz

  • Cc sergz added
  • Owner set to sergz

comment:4 Changed on 11/21/2016 at 10:05:19 AM by abpbot

A commit referencing this issue has landed:
Issue 769 - replace auto_ptr by unique_ptr and use proper delete[ operator]

comment:5 Changed on 11/21/2016 at 10:06:49 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.