Some yahoo page not correctly shown on IE8 when ABP enabled

[passbrains]

Adapted from ​https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-23

Environment

Windows 7 64bit Internet Explorer 8 English
ABP version 1.2.636.0

How to reproduce

1. ABP is enabled for IE.
2. Launch ​https://uk.eurosport.yahoo.com/snooker website.

Observed behaviour

Links and images are all distorted.

Expected behaviour

Page should be load properly

[passbrains]

1 - 23 Jul 2014 12:51:20 posted by Philip Hill
I am pretty certain that you did not use the latest dev build but instead an older one. As you posted the download URL as version number, i so far cannot prove it. So first, please FOR ALL YOUR REPORTS learn how to find the version number of your Adblock Plus installation (See "Other Notes:" section in test description) and second of all ensure to get the latest version at least daily.

2 - 23 Jul 2014 12:58:45 posted by Philip Hill
Okay, after reproducing this myself, I found that IE 8 still shows the buggy behaviour, while IE 11 after https://issues.adblockplus.org/ticket/270 works well.

[sergz]

The trouble is that the style sheet is blocked. The ACCEPT header in IE8 is */*, so we cannot derive mime type from it and we should try to fallback to use URL, which is
https://s1.yimg.com/zz/combo?d/lib/yui/3.4.1/build/cssreset/cssreset-min.css&d/lib/yui/3.4.1/build/cssfonts/cssfonts-min.css&os/mit/media/p/presentation/grids/master-min-a143923.css&os/mit/media/p/presentation/grids/desktop-min-8723999.css&os/mit/media/p/presentation/base/master-min-8723999.css&os/mit/media/p/presentation/base/desktop-min-a143923.css&os/mit/media/m/header/header-desktop-min-7783740.css&os/mit/media/m/ads/ads-min-81b3fea.css&os/mit/media/m/navigation/navigation-desktop-min-a8a04a0.css&os/mit/media/m/heading/heading-min-1652721.css&os/mit/media/m/footer/footer_sponsor-min-66303b2.css&os/mit/media/m/footer/footer_links-min-66303b2.css&os/mit/media/m/linkbox/linkbox-min-248956.css&os/mit/media/m/footer/footer_info-min-66303b2.css&os/mit/media/m/footer/footer_info-desktop-min-43b1bcf.css

The path is /zz/combo (see WBPassthruSink::GetContentTypeFromURL) and it does not contain anything about CSS, it seems the server script which glues specified CSS in query string into one.

[sergz]

If we cannot detect the content type from path then we could try with the query string. Although I'm not sure whether it makes sense to analyze query string of the URL because

• for the site makers it's very easy to modify it
• we can wrongly interpret it

Split it into parameters and find let's say the first parameter which has some known extension, like ccs, js, swf. What do you think?

One may check the code here ​http://codereview.adblockplus.org/5921969115496448/

[sergz]

I've tested the previous approach pOIBindInfo->GetBindString(BINDSTRING_ACCEPT_MIMES, mime, 10, &resLen); on IE8, it seems always returning */* and the resLen = 1. In IE 11 resLen varies from 2 to 4 and it indeed contains a lot, for example:

​https://s1.yimg.com/zz/combo?d/lib/yui/3.4.1/build/cssreset/cssreset-min.css&d/lib/yui/3.4.1/build/cssfonts/cssfonts-min.css&os/mit/media/p/presentation/grids/master-min-a143923.css&os/mit/media/p/presentation/grids/desktop-min-8723999.css&os/mit/media/p/presentation/base/master-min-8723999.css&os/mit/media/p/presentation/base/desktop-min-a143923.css&os/mit/media/m/header/header-desktop-min-7783740.css&os/mit/media/m/ads/ads-min-81b3fea.css&os/mit/media/m/navigation/navigation-desktop-min-a8a04a0.css&os/mit/media/m/heading/heading-min-1652721.css&os/mit/media/m/footer/footer_sponsor-min-66303b2.css&os/mit/media/m/footer/footer_links-min-66303b2.css&os/mit/media/m/linkbox/linkbox-min-248956.css&os/mit/media/m/footer/footer_info-min-66303b2.css&os/mit/media/m/footer/footer_info-desktop-min-43b1bcf.css

text/css
*/*

​https://s1.yimg.com/os/mit/media/m/base/images/transparent-649ba6f.png

image/png
image/svg+xml
image/*;q=0.8
*/*;q=0.5}}}