Opened on 12/15/2014 at 11:23:46 AM
Closed on 01/06/2015 at 02:14:47 PM
Last modified on 02/19/2015 at 07:35:39 AM
#1699 closed change (fixed)
Missed using of url to detect request type
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | #1115 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
In src\plugin\PluginWbPassThrough.cpp we call GetContentTypeFromMimeType(ATL::CString(acceptHeader.c_str())); but in IE8 it's very often */*, so the type is other.
What to change
Call GetContentType(ATL::CString(acceptHeader.c_str()), m_boundDomain, ToCString(src));.
Attachments (0)
Change History (5)
comment:1 Changed on 12/15/2014 at 11:28:38 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/05/2015 at 12:05:53 PM by oleksandr
- Platform changed from Unknown to Internet Explorer
- Ready set
comment:3 Changed on 01/05/2015 at 12:06:07 PM by oleksandr
- Priority changed from Unknown to P3
comment:4 Changed on 01/06/2015 at 02:14:47 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 02/19/2015 at 07:35:39 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See
TracTickets for help on using
tickets.
