Opened on 07/23/2014 at 03:22:49 PM
Closed on 10/30/2014 at 12:22:51 PM
Last modified on 10/30/2014 at 12:26:20 PM
#1122 closed defect (fixed)
ABP stops element selection after cancel button was clicked in the 'Add Filer(s)?' popup
| Reported by: | passbrains | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-13
Environment
Windows 7 64bit Chrome English
ABP version 1.8.3.1204
How to reproduce
- Go to http://timesofindia.indiatimes.com/ or http://maanimo.com/
- Click ABP icon and select "Block element" option
- Select any blockable element on the page
- Click Cancel button in the "Add Filer(s)?" dialog
- Try selecting other elements
- Click ABP icon again
Observed behavior
The bubble UI indicates that you are still in "Block element" mode (you have to click "Cancel"). However, you can't select another element from the page.
Expected behavior
When clicking "Cancel" in the "Add Filer(s)?" dialog, the bubble should leave "Block element" mode, returning to its initial state.
Attachments (1)
Change History (10)
Changed on 07/23/2014 at 03:22:51 PM by passbrains
comment:2 Changed on 08/27/2014 at 06:49:50 PM by sebastian
- Cc sebastian added
- Component changed from Unknown to Platform
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
In fact, I can't reproduce it on http://timesofindia.indiatimes.com/, but on http://maanimo.com/.
comment:3 Changed on 09/03/2014 at 09:20:18 AM by saroyanm
- Owner set to saroyanm
comment:4 Changed on 09/03/2014 at 11:57:14 AM by saroyanm
This issue is appears because "page.sendMessage" method which in case of Chrome uses chrome.tabs.sendMessage API, is sending the message to all content scripts of the page which also include content scripts loaded into iframes, in include.postload we change the state of clickHide_activated boolean variable (which indicates whether we should show cancel button for block dialog in popup) after closing block dialog only in the content script of frame where it's loaded, looks like the top frame and so in the popup.js after calling "page.sendMessage" with type of get-clickhide-state we always getting the state of clickHide_activated variable of random content script (not sure in which order message to content scripts of the page is sent) in the page, so most likely that this issue will persist on pages that contains lot of iframes.
comment:5 Changed on 09/04/2014 at 01:03:31 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 10/30/2014 at 10:01:51 AM by sebastian
- Priority changed from P3 to P2
With the current devbuild this happens on all websites when you have used "Block element".
comment:7 Changed on 10/30/2014 at 12:22:36 PM by saroyanm
comment:8 Changed on 10/30/2014 at 12:22:51 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 10/30/2014 at 12:26:20 PM by saroyanm
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Manually copied description from passbrains. It were truncated due to #1275.