Opened on 07/24/2014 at 07:46:58 AM
Closed on 08/20/2014 at 02:23:14 PM
Last modified on 09/17/2014 at 04:27:03 PM
#1128 closed change (fixed)
ADC logo/icon added to acceptableads.org
Reported by: | ben | Assignee: | greiner |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Websites | Keywords: | manifesto |
Cc: | sven, greiner, innerself, trev | Blocked By: | |
Blocking: | #1240 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by greiner)
Background
The Art Directors Club (ADC) would like to join the Acceptable Ads Manifesto on acceptableads.org
What to change
- Insert ADC (logo is attached) in the signatories logos list between Adblock Plus and Auxilium Gaming Community
- Hide Unwatch.Me in the signatories logos list
- Add an "Additional organizations" link to the bottom-left of the signatories logos list which, when clicked, reveals organizations at the end of the list that are not shown by default (in this case it's only Unwatch.Me).
Attachments (2)
Change History (15)
Changed on 07/24/2014 at 07:47:19 AM by ben
Changed on 07/24/2014 at 02:46:40 PM by sven
comment:1 Changed on 07/30/2014 at 08:42:56 AM by greiner
Keep in mind that since #628 has now been closed there are already two rows of signatories which means that adding another icon would create a third row. Therefore we might want to wait for more organizations and design a new overflow mechanism to put them somewhere without overloading the page.
comment:2 Changed on 07/30/2014 at 03:11:54 PM by ben
Yes, we definitely need a new overflow mechanism. I would recommend one that just says "Additional organizations" and displays all additional icons in rows when clicked. Since the top row should remain static, we should remove the last organization to sign up from the second row, i.e. Auxilium Gaming. That's the most fair way.
comment:3 Changed on 07/30/2014 at 03:32:59 PM by sven
the suggestion by @ben is fine for me
comment:4 follow-up: ↓ 5 Changed on 07/31/2014 at 08:29:51 AM by greiner
Some remaining questions:
1) Should we wait for more organizations before tackling this?
2) Where should that link appear? At the same spot the "show all"/"hide all" link was located?
3) It sounds like you want them to be sorted chronologically by date of joining the manifesto from newest to oldest. Is that correct? If that's the case please provide the order they should appear in.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed on 07/31/2014 at 02:48:47 PM by ben
Replying to greiner:
Some remaining questions:
1) Should we wait for more organizations before tackling this?
I don't think so. ADC is keen to be listed soon, and I don't see any reason to wait.
2) Where should that link appear? At the same spot the "show all"/"hide all" link was located?
Yeah, I think it makes sense there, i.e. right under the bottom-left icon.
3) It sounds like you want them to be sorted chronologically by date of joining the manifesto from newest to oldest. Is that correct? If that's the case please provide the order they should appear in.
Actually, if we always remove the newest signatory it could mean that organizations get bumped without having their icon displayed for very long. A better idea would be to remove the oldest signatory from the second row whenever someone new joins. So we should remove Unwatch.me, shift all remaining second-row icons right and fill the bottom-left spot with ADC.
However, I would reserve the right to keep new signatories listed in the second row longer if they contribute something to the project. Like ADC, which has agreed to promoting the Manifesto to its members.
comment:6 in reply to: ↑ 5 Changed on 07/31/2014 at 05:39:49 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
Replying to ben:
I don't think so. ADC is keen to be listed soon, and I don't see any reason to wait.
The reason is that only a single organization would be shown after clicking on the "Additional organizations" link. But if we can agree on this not being an actual issue then we can ignore that.
However, I would reserve the right to keep new signatories listed in the second row longer if they contribute something to the project.
That's fine as long as the position is specified where exactly the logo should be inserted.
comment:7 Changed on 08/13/2014 at 09:59:16 AM by ben
What's the status on this? I would like to let them know soon that their icon is up if there are no outstanding issues/unanswered questions.
comment:8 Changed on 08/13/2014 at 10:33:32 AM by greiner
- Owner set to greiner
- Ready set
comment:9 Changed on 08/13/2014 at 11:09:58 AM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:10 Changed on 08/20/2014 at 02:23:14 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
I applied greiner's changes from the review:
https://hg.adblockplus.org/www/rev/c9e46a46f4bc
https://hg.adblockplus.org/www/rev/39aa58b1e37e
Also fixed various links in that page:
comment:11 Changed on 08/20/2014 at 02:23:40 PM by trev
- Cc trev added
comment:12 Changed on 08/29/2014 at 05:35:37 PM by greiner
- Blocking 1240 added
comment:13 Changed on 09/17/2014 at 04:27:03 PM by trev
- Component changed from Infrastructure to Websites
Scaled adc global logo