Opened on 07/24/2014 at 07:49:02 AM

Closed on 08/07/2014 at 08:25:16 AM

Last modified on 05/20/2015 at 02:22:39 PM

#1129 closed defect (fixed)

Disabling filters via space bar does no longer work

Reported by: arthur Assignee: saroyanm
Priority: P3 Milestone: Adblock-Plus-2.6.5-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5331420155215872/

Description

Environment

Firefox 31
ABP 2.6.3 and 2.6.4.3852
Windows 8.1 Pro x64 Update 1

How to reproduce

  1. Open the filter preferences
  2. Show the filters of any filter subscription if necessary
  3. Click on any enabled/ticked filter
  4. Press the space bar

Observed behaviour

Nothing happens.

Expected behaviour

The selected filter should be disabled.

Attachments (0)

Change History (6)

comment:1 Changed on 07/24/2014 at 10:20:16 AM by mapx

  • Cc mapx added

comment:2 Changed on 08/06/2014 at 04:31:06 PM by saroyanm

  • Owner set to saroyanm

comment:3 Changed on 08/06/2014 at 06:23:50 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/07/2014 at 08:25:16 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Revision:
​https://hg.adblockplus.org/adblockplus/rev/9ce6d202f294

comment:5 Changed on 08/07/2014 at 12:51:33 PM by saroyanm

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:6 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.