Opened on 07/24/2014 at 09:18:22 AM

Last modified on 06/03/2015 at 03:17:39 PM

#1130 reviewing change

Don't assume that %WIX%\bin is in %PATH%

Reported by: fhd Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug installer
Cc: Mailkov, oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

We're currently calling the WiX tools (candle.exe etc.) assuming they're on %PATH%. We should call them relative to %WIX% instead, which is set when installing WiX.

Once this is done, we can remove the remark about adding %WIX%\bin to %PATH% from the README.

Attachments (0)

Change History (6)

comment:1 Changed on 07/24/2014 at 09:22:36 AM by fhd

  • Keywords goodfirstbug added

comment:2 Changed on 08/14/2014 at 02:05:32 PM by fhd

  • Keywords installer added

comment:3 Changed on 01/15/2015 at 06:39:52 PM by Mailkov

Hi , I would like to work on this change

comment:4 Changed on 05/18/2015 at 12:19:24 PM by Mailkov

Pull request: ​https://github.com/adblockplus/adblockplusie/pull/14

comment:5 Changed on 05/30/2015 at 10:58:32 AM by Mailkov

Can you assign it to me? So I will receive e-mail on this issue.

comment:6 Changed on 06/03/2015 at 03:17:39 PM by oleksandr

  • Cc Mailkov oleksandr added
  • Status changed from new to reviewing

Add Comment

Modify Ticket

Change Properties
Action
as reviewing .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.