Opened on 07/31/2014 at 08:27:20 AM
Closed on 08/06/2014 at 03:19:30 PM
Last modified on 08/07/2014 at 01:51:41 PM
#1166 closed change (fixed)
Import strings from ABP for Firefox
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.2-for-Internet-Explorer |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | #1179 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Since we have some of the same strings (particularly regarding Acceptable Ads), we should import them directly from Firefox.
What to change
We have something similar in Chrome already, it should work like that. buildtools/localeTools.py has a readFile function that can parse Firefox translation files.
Attachments (0)
Change History (5)
comment:1 Changed on 07/31/2014 at 08:33:15 AM by fhd
- Owner set to fhd
comment:2 Changed on 08/05/2014 at 04:17:32 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/06/2014 at 11:27:52 AM by fhd
- Blocking 1179 added
comment:4 Changed on 08/06/2014 at 03:19:30 PM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/07/2014 at 01:51:41 PM by fhd
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.2
Note: See
TracTickets for help on using
tickets.
What's still missing is the "Adblock Plus has been updated" text. We had that in Chrome, but it has been removed. We can retrieve the old translations from there.