Opened on 08/07/2014 at 02:48:45 PM
Closed on 11/17/2015 at 07:17:11 PM
Last modified on 11/21/2016 at 10:43:39 AM
#1186 closed change (fixed)
[Installer cleanup] Make the naming comply with our coding style
| Reported by: | fhd | Assignee: | eric@adblockplus.org |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | installer |
| Cc: | Blocked By: | ||
| Blocking: | #1184 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
http://codereview.adblockplus.org/5219280069066752/ |
||
Description (last modified by fhd)
Background
See #1184.
What to change
The installer code is in general quite far from our [coding style](https://adblockplus.org/en/coding-style). Aside the formatting, naming is also both inconsistent within the installer and with our coding style. That needs to be fixed.
We should make the file naming comply with our conventions in the same step: Should be camel case, generally the name of the major namespace or class in that file.
Attachments (0)
Change History (15)
comment:1 Changed on 08/07/2014 at 02:49:17 PM by fhd
- Summary changed from [Installer cleanup] Fix naming to [Installer cleanup] Make the naming comply with our coding style
comment:2 Changed on 08/07/2014 at 02:50:27 PM by fhd
- Blocking 1184 added
comment:3 Changed on 08/08/2014 at 05:39:29 PM by fhd
- Blocking 1189 added
comment:5 Changed on 08/14/2014 at 02:04:32 PM by fhd
- Keywords installer added
comment:6 Changed on 09/30/2014 at 08:31:48 AM by fhd
- Blocking 1189 removed
comment:7 Changed on 09/30/2014 at 08:37:03 AM by fhd
- Priority changed from P3 to P2
comment:8 Changed on 01/15/2015 at 11:32:00 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:9 Changed on 01/16/2015 at 09:03:33 AM by oleksandr
- Owner set to eric@…
comment:10 Changed on 02/02/2015 at 12:56:23 PM by eric@adblockplus.org
- Owner changed from eric@… to eric@adblockplus.org
- Review URL(s) modified (diff)
comment:11 Changed on 02/19/2015 at 08:38:55 AM by oleksandr
- Milestone Adblock-Plus-for-Internet-Explorer-1.4 deleted
comment:12 Changed on 10/13/2015 at 07:23:44 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
- Tester set to Unknown
comment:13 Changed on 11/17/2015 at 07:10:50 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:14 Changed on 11/17/2015 at 07:17:11 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from new to closed
comment:15 Changed on 11/21/2016 at 10:43:39 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See
TracTickets for help on using
tickets.
Increasing priority - we should tackle this before the other installer issues.