Opened on 08/08/2014 at 09:05:08 AM
Closed on 01/13/2015 at 03:03:22 PM
Last modified on 01/16/2015 at 09:01:54 AM
#1187 closed change (fixed)
[Installer cleanup] Do not leak MSIHANDLEs in custom action
| Reported by: | oleksandr | Assignee: | eric@adblockplus.org |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | installer |
| Cc: | oleksandr | Blocked By: | #1762 |
| Blocking: | #1184 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Our installer custom action is leaking 2 MSIHANDLEs (as can be seen by the verbose install log).
What to change
Fix the leakage and close all MSIHANDLEs properly
Attachments (0)
Change History (9)
comment:1 Changed on 08/08/2014 at 09:05:50 AM by oleksandr
- Summary changed from [Installer cleanup] to [Installer cleanup] Do not leak MSIHANDLEs in custom action
comment:2 Changed on 08/14/2014 at 02:06:10 PM by fhd
- Keywords installer added
comment:3 Changed on 09/30/2014 at 08:37:03 AM by fhd
- Priority changed from Unknown to P2
comment:4 Changed on 01/05/2015 at 06:09:44 PM by eric@adblockplus.org
I'm not getting the leakage message reliably under Windows 7. In some circumstances, it's not leaking at all. In others, it's leaking one handle. I haven't seen it leak two handles under any circumstances.
The differing circumstances that my be relevant include (1) Windows version, (2) installer version, release or devbuild, (3) whether IE is running at any point during installation, (4) if relevant, what the responses to the dialogs from the CloseIe custom action are.
Last edited on 01/05/2015 at 06:23:50 PM
by eric@adblockplus.org
comment:5 Changed on 01/07/2015 at 06:05:46 PM by eric@adblockplus.org
- Blocked By 1762 added
comment:6 Changed on 01/07/2015 at 10:29:53 PM by eric@adblockplus.org
- Owner set to eric@adblockplus.org
- Review URL(s) modified (diff)
comment:7 Changed on 01/07/2015 at 10:30:05 PM by eric@adblockplus.org
- Status changed from new to reviewing
comment:8 Changed on 01/13/2015 at 03:03:22 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 01/16/2015 at 09:01:54 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See
TracTickets for help on using
tickets.
Increasing priority - we should tackle this before the other installer issues.