Opened on 08/12/2014 at 03:23:43 PM
Closed on 06/01/2015 at 09:23:30 AM
#1201 closed defect (fixed)
Enabling/disabling ABP everywhere applies only in the next opened tab
| Reported by: | philll | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.5 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | #1728, #2230 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by oleksandr)
Environment
Win 7 32 bit
Testes in IE 8,9,11
ABP 1.2
Easylist Germany & Easylist
Acceptable ads enabled
How to reproduce
- Go to http://www.heise.de/
- Watch out for some not blocked image ad in the right column
- Click the ABP button
- Disable blocking everywhere
- Reload the tab with heise.de
Observed behaviour
The ads are still blocked
Expected behaviour
The ad should not be blocked/hidden.
Attachments (0)
Change History (10)
comment:1 Changed on 12/19/2014 at 11:46:03 AM by sergz
- Owner set to sergz
comment:2 Changed on 01/12/2015 at 10:50:22 AM by sergz
- Owner sergz deleted
I will come back after finishing with injecting of CSS because it highly depends on the code of css injection as well as it will be better visible how to do it.
comment:3 Changed on 01/16/2015 at 09:05:13 AM by oleksandr
- Cc oleksandr added
comment:4 Changed on 01/21/2015 at 12:29:13 PM by oleksandr
- Blocking 1728 added
comment:5 Changed on 01/21/2015 at 12:31:18 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:6 Changed on 03/27/2015 at 07:30:30 AM by oleksandr
- Owner set to oleksandr
- Summary changed from setting changes in ABP for IE don't apply when reloading, but in other tabs to Enabling/disabling ABP everywhere applies only in the next opened tab
comment:7 Changed on 03/27/2015 at 08:04:01 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 03/30/2015 at 01:07:59 PM by oleksandr
- Blocking 2230 added
comment:10 Changed on 06/01/2015 at 09:23:30 AM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Despite I cannot reproduce it on http://www.heise.de/, may be we need to find another web site or create some synthetic page for tests, there is the possibility for such behaviour.
When the user refreshes the page the before navigate is not fired and we don't reload filters. Thus the traverser which is called on download complete as well as css injector which is called on document ready state complete use the obsolete filters.
The first time (start page is about:blank) it takes about 150 msec to get element hiding selectors, other times it takes about 75 msec (+/- 10 msec). So I would suppose firstly reload them each time we are going to use them and only afterward if it hurts we can make some optimization as another issue.