Opened on 08/14/2014 at 05:22:24 AM
Last modified on 12/11/2014 at 11:26:58 AM
#1221 new defect
Installing ABP 1.2 doesn't remove the old version
| Reported by: | Gingerbread Man | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | installer |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by oleksandr)
Environment
Me: Windows XP SP3 • Internet Explorer 8
Others: Windows 7 x64 SP1 • Internet Explorer 11
How to reproduce
- Run the installer for Adblock Plus 1.2 on a system that already has 1.1 installed.
Observed behavior
The version 1.1 isn't removed, or at least an entry is still listed in Control Panel.
Expected behavior
The version 1.1 should be removed and no uninstall entry for it should appear in Control Panel.
Forum thread
Attachments (1)
Change History (8)
Changed on 08/14/2014 at 05:22:43 AM by Gingerbread Man
comment:1 Changed on 08/14/2014 at 01:48:04 PM by fhd
I've seen this too - ABP for IE is actually getting removed though, there's just a leftover entry from Burn. I'm not exactly sure if it would make sense to remove that via the MSI uninstallation.
comment:2 Changed on 08/14/2014 at 01:48:34 PM by fhd
- Keywords installer added
comment:3 Changed on 08/14/2014 at 09:19:25 PM by eric@adblockplus.org
Given the way that burn works, it may well be easiest to use burn to remove that entry. We might be able to bundle a burn-based uninstaller for that rump entry into the InnoSetup packager.
Regardless, burn requires its own separate GUID, apart from the Product GUID that's in the MSI's. It's called UpgradeCode in the burn source. Nothing without that GUID there is going to (cleanly) uninstall that old entry.
comment:4 Changed on 09/30/2014 at 08:19:39 AM by fhd
- Priority changed from P2 to P3
Reducing priority - not critical enough for a P2.
comment:5 Changed on 12/11/2014 at 11:25:05 AM by oleksandr
- Priority changed from P3 to P4
To update this ticket: update from 1.2 to 1.3 *will* remove the previous version entry. It's only 1.1 leftovers that are not being cleaned up. Considering that, I am reducing priority even more.
comment:6 Changed on 12/11/2014 at 11:25:28 AM by oleksandr
- Ready set
abpie_duplicate.png