Opened on 08/14/2014 at 09:36:20 PM
Closed on 08/14/2014 at 09:42:12 PM
Last modified on 10/13/2014 at 01:26:58 PM
#1232 closed change (fixed)
[Stop using ATL] Replace ATL::CSimpleArray with std::set
| Reported by: | eric@adblockplus.org | Assignee: | eric@adblockplus.org |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.3 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | #276 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by eric@adblockplus.org)
Background
We use ATL::CSimpleArray.
What to change
Replace it with std::set.
Hints for testers
There's only one place where this data structure was used, and it involves the ABP icon in the status bar. Misbehavior in the affected code would involve the icon not appearing correctly, not responding, responding incorrectly, or other similar kinds of misbehavior.
Attachments (0)
Change History (9)
comment:1 Changed on 08/14/2014 at 09:36:36 PM by eric@adblockplus.org
- Summary changed from Replace ATL::CSimpleArray with std::set. to Replace ATL::CSimpleArray with std::set
comment:2 Changed on 08/14/2014 at 09:42:12 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 08/15/2014 at 05:39:26 AM by fhd
- Priority changed from Unknown to P4
- Ready set
- Summary changed from Replace ATL::CSimpleArray with std::set to [Stop using ATL} Replace ATL::CSimpleArray with std::set
comment:4 Changed on 08/15/2014 at 05:40:36 AM by fhd
- Summary changed from [Stop using ATL} Replace ATL::CSimpleArray with std::set to [Stop using ATL] Replace ATL::CSimpleArray with std::set
comment:6 Changed on 08/25/2014 at 09:14:26 AM by trev
- Cc trev added
comment:7 Changed on 08/25/2014 at 09:15:12 AM by trev
- Owner set to eric@adblockplus.org
comment:8 Changed on 10/13/2014 at 11:17:34 AM by trev
- Milestone set to Adblock-Plus-for-Internet-Explorer-next
This apparently landed with https://hg.adblockplus.org/adblockplusie/rev/cafe08d45329.
Eric, still waiting for you to update the description of this issue.
Note: See
TracTickets for help on using
tickets.
Eric, could you please modify the description of this issue and add hints for testers? It is very non-obvious which functionality is affected by this issue.