Opened on 08/14/2014 at 10:11:46 PM

Closed on 10/21/2014 at 11:56:37 PM

#1233 closed change (rejected)

[Stop using ATL] Replace ATL::CComBSTR

Reported by: eric@adblockplus.org Assignee:
Priority: P5 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: #276 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

We are using ATL::CComBSTR. In almost every case, it's used as an interface class for API calls.

Apart from being an ATL class, it also does not have standard conversion to and from std::wstring, which has led to inconsistency at its point of use.

What to change

Replace CComBSTR with non-ATL code. Such code must properly manage the life cycle of BSTR and also provide conversions back and forth to std::wstring.

Attachments (0)

Change History (5)

comment:1 Changed on 08/15/2014 at 05:39:41 AM by fhd

  • Priority changed from Unknown to P4
  • Ready set
  • Summary changed from Replace ATL::CComBSTR to [Stop using ATL} Replace ATL::CComBSTR

comment:2 Changed on 08/15/2014 at 05:40:49 AM by fhd

  • Summary changed from [Stop using ATL} Replace ATL::CComBSTR to [Stop using ATL] Replace ATL::CComBSTR

comment:3 Changed on 10/07/2014 at 01:25:11 PM by oleksandr

  • Priority changed from P4 to P5

comment:4 Changed on 10/21/2014 at 11:56:07 PM by oleksandr

We have decided that there is very little incentive to replace CComBSTR, since we are not going to remove all of the ATL references anyway. Hence this issue can be closed.

comment:5 Changed on 10/21/2014 at 11:56:37 PM by oleksandr

  • Resolution set to rejected
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.