Opened on 08/24/2014 at 02:47:57 PM
Closed on 08/26/2014 at 12:57:36 PM
Last modified on 10/01/2014 at 11:43:48 AM
#1262 closed defect (fixed)
Wrong proxy configuration message for devices with Android >2.3
Reported by: | fhd | Assignee: | |
---|---|---|---|
Priority: | P1 | Milestone: | Adblock-Plus-for-Android-1.3 |
Module: | Adblock-Plus-for-Android | Keywords: | |
Cc: | rjeschke | Blocked By: | |
Blocking: | Platform: | Android | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
Environment
Adblock Plus for Android Revision 333 on Android 4.4.
How to reproduce
- Start the app on a device running Android >4.2.2.
- Touch "configuration"
Observed behaviour
The message says that you're running a device with Android 2.3 or older, and that proxy configuration is not supported.
Expected behaviour
There should be a message explaining how to configure the proxy on Android >4 devices.
Attachments (0)
Change History (4)
Note: See
TracTickets for help on using
tickets.
The reason for this is that checks for ProxyService.NATIVE_PROXY_SUPPORTED have been replaced with Utils.isNativeProxySupported(this). However, the former used to mean "this device supports proxy configuration AT ALL", while the latter means: "This device supports _automatic_ configuration of the proxy." - two different things we confusingly used the same term for.