Opened on 08/24/2014 at 02:48:16 PM
Closed on 11/10/2017 at 11:15:18 AM
#1263 closed defect (rejected)
Custom filter don't work anymore after ABP update
| Reported by: | sebastian | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | fhd, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by philll)
Attachments (1)
Change History (9)
Changed on 08/24/2014 at 02:48:33 PM by sebastian
comment:1 Changed on 08/24/2014 at 02:52:43 PM by sebastian
- Cc fhd added
- Description modified (diff)
comment:2 Changed on 08/24/2014 at 04:57:05 PM by mapx
- Cc mapx added
comment:4 follow-ups: ↓ 5 ↓ 6 Changed on 08/25/2014 at 07:16:48 AM by fhd
This was a real life bug report. The problem description was, roughly: "My custom filters on gmx.net don't work anymore since the last Adblock Plus or Firefox update."
Does sound like a regression.
comment:6 in reply to: ↑ 4 Changed on 09/22/2014 at 04:44:50 AM by Gingerbread Man
Replying to sebastian:
That is hilarious.
Replying to fhd:
Does sound like a regression.
Those are simplified hiding filters. Even if you didn't remove support for them intentionally, why would you want to spend any time re-adding support for them? Wladimir planned to remove support for simplified syntax as far back as April 2009. Even the documentation warns about it.
- https://adblockplus.org/en/filters#elemhide_simplified
- https://adblockplus.org/forum/viewtopic.php?f=4&t=3812
The user should use CSS selectors, like so:
www.gmx.net##div[class="news content"] www.gmx.net##div.r2 www.gmx.net##div.r1 logout.gmx.uimserv.net##div#innerContent
Specifying the element type for that last one is probably redundant, since id attributes are supposed to be unique:
logout.gmx.uimserv.net###innerContent
comment:7 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
comment:8 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
Avoided the image to spam the timeline. Please provide more details for this issue.