Opened on 09/11/2014 at 06:40:05 PM
Closed on 01/11/2015 at 07:34:36 PM
#1364 closed change (fixed)
Make Element Hiding Helper & Co. use the new dependencies mechanism
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Element-Hiding-Helper-1.3.1 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | #170, #1363 | |
| Blocking: | #1588, #1757 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by kzar)
Background
In #170 we introduced our custom dependency mechanism, we should have the simple extensions use it first.
What to change
Change the following extensions:
- Adblock Plus Crawler
- Customization for Adblock Plus
- Diagnostics for Adblock Plus
- Adblock Plus Tests
- Element Hiding Helper for Adblock Plus
- URL Fixer
- Add the ensure_dependencies.py script to the root of each repository.
- Migrate the contents of the .hgsub and .hgsubstate files to a dependencies file for use by the ensure_dependencies.py script. (See ticket #170 and the script itself for more information about the format. See the infrastructure repository for a working example.)
- Update build.py to execute the ensure_dependencies.py script as a subprocess before running tasks.
Attachments (0)
Change History (9)
comment:1 Changed on 09/11/2014 at 07:00:22 PM by trev
- Owner set to trev
comment:2 Changed on 09/11/2014 at 07:08:21 PM by trev
- Owner trev deleted
comment:3 Changed on 11/20/2014 at 03:13:58 PM by trev
- Blocking 1588 added
comment:4 Changed on 12/01/2014 at 03:02:02 PM by poz2k4444
- Owner set to poz2k4444
comment:5 Changed on 01/06/2015 at 01:23:06 PM by poz2k4444
- Blocking 1757 added
comment:8 Changed on 01/10/2015 at 09:07:38 AM by trev
- Owner changed from poz2k4444 to trev
- Review URL(s) modified (diff)
comment:9 Changed on 01/11/2015 at 07:34:36 PM by trev
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Fixed:
https://hg.adblockplus.org/abpcrawler/rev/12276a824aae
https://hg.adblockplus.org/abpcustomization/rev/f1db9b295999
https://hg.adblockplus.org/abpwatcher/rev/4d7eb816ad5a
https://hg.adblockplus.org/adblockplustests/rev/e7a3c56b9445
https://hg.adblockplus.org/elemhidehelper/rev/4377c57fd78e
https://hg.adblockplus.org/urlfixer/rev/8d7a8ca05560
I compared the generated builds before and after the change. Crawler, Customization and Diagnostics has rather outdated buildtools dependencies so there were additional changes - all related to buildtools fixes. For the other extensions identical builds with minimal differences (esp. license texts) were generated.